vsc: add source to common fields
#977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The `source` value has become a common pattern in our telemetry which answers "who" caused the metric event. For example if we had a function() to open a menu, there could be many different entrypoints that could call it. Solution: `source` will answer "who" it was for that event. And now it will be a part of all metrics as an optional field. Note: The other IDEs should consider following this pattern if not already. Signed-off-by: nkomonen-amazon <[email protected]>
nkomonen-amazon
force-pushed
the
sourceBase
branch
from
377adcd to
0802713
Compare
Contributor
|
Can you add this to the C# generator too? |
justinmk3
reviewed
Feb 20, 2025
justinmk3
approved these changes
Feb 20, 2025
justinmk3
changed the title
source to common fieldssource to common fields
jpinkney-aws
approved these changes
Feb 20, 2025
nkomonen-amazon
force-pushed
the
sourceBase
branch
from
aeeeeed to
0802713
Compare
nkomonen-amazon
changed the title
source to common fieldssource to common fields
nkomonen-amazon
added a commit
that referenced
this pull request
Feb 21, 2025
Follow up to: #977 but for VS/C# <!--- REMINDER: - Read CONTRIBUTING.md first. - Add test coverage for your changes. - Link to related issues/commits. - Testing: how did you test your changes? - Screenshots if applicable --> ## License By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: nkomonen-amazon <[email protected]> Co-authored-by: Christopher Christou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The
sourcevalue has become a common pattern in our telemetry which answers "who" caused the metric event. For example if we had a function() to open a menu, there could be many different entrypoints that could call it.Right now we have to add
sourceto each metric that uses it, but this usage has increased for a lot of metrics.Solution:
sourcewill be a part of all metrics as an optional field.TODO
The other IDEs should consider following this pattern if not already.
If all IDEs implement this then we can remove the explicit requirements of
sourceincommonDefinitions.jsonLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.